Skip to content

Fix repo-wide lint failure: sort package.json for ultracite 7.10 - #165

Merged
AdamXweb merged 1 commit into
mainfrom
fix/sort-package-json
Aug 4, 2026
Merged

Fix repo-wide lint failure: sort package.json for ultracite 7.10#165
AdamXweb merged 1 commit into
mainfrom
fix/sort-package-json

Conversation

@adamXbot

@adamXbot adamXbot commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Fix the repo-wide quality failure

pnpm lint has failed on every branch including main since #154. One-file fix.

Cause

#154 (Renovate, "update all non-major dependencies") raised ultracite 7.9.4 → 7.10.0, which added the assist/source/useSortedPackageJson rule. The repo's package.json doesn't satisfy it:

package.json:1:1 assist/source/useSortedPackageJson  FIXABLE
  × package.json fields can be organized.

main's own package.json reproduces it — I checked it in isolation. None of the open PRs touch that file, so #162, #163 and #164 are all inheriting the failure, not causing it. Their other 7 checks pass.

This is the second CI break from that single PR. It also bumped packageManager to pnpm@11.18.0, whose default 24-hour minimumReleaseAge then rejected the ultracite version the same commit introduced — that one cleared itself once the package aged out. #154 was merged with a red quality job, which is how both landed.

Why sort rather than disable the rule

biome.jsonc does turn off the sibling useSortedKeys, so there's precedent — but its two stated reasons don't carry here. The non-negotiable one is that object key order is observable in persisted snapshot_json, where getChangelog compares wayback and live rows byte-identically; package.json isn't in that path. The other is churn across ~600 files, and this is one file.

A rule that's merely opinionated isn't worth a config exception.

The change is purely a reordering — keys, values, scripts, dependencies and devDependencies all compare equal to the previous file.

Verification

  • biome check package.json → clean
  • biome check package.json biome.jsonc tsconfig.json app lib tests scripts locales651 files, no fixes
  • tsc clean, 444 unit tests pass

Note on how I missed this

My per-pass verification ran biome check app/ lib/ tests/ scripts/, which never included the repo-root package.json — so I reported "lint clean" on branches whose quality job was red. A pathless ultracite check would have caught it, but it can't be used here: biome.jsonc excludes **/.claude, and this work happens in a worktree under .claude/worktrees/, so a pathless run reports "Checked 0 files". I've been passing explicit paths for that reason, and the path list was incomplete.

Merging

Once this lands, #162/#163/#164 need main merged in (or the Update branch button) to pick it up and re-run.

🤖 Generated with Claude Code

`pnpm lint` has failed on every branch, including main, since the
Renovate bump in #154. That PR raised ultracite 7.9.4 -> 7.10.0, which
added `assist/source/useSortedPackageJson`, and the repo's package.json
does not satisfy it. #154 was itself merged with a red `quality` job.

This is the second CI break from that one PR — it also bumped
packageManager to pnpm@11.18.0, whose default 24h `minimumReleaseAge`
rejected the ultracite version the same commit introduced, until it aged
out.

Applying the sort rather than switching the rule off. biome.jsonc does
disable the sibling `useSortedKeys`, but for two stated reasons and the
non-negotiable one — object key order being observable in persisted
`snapshot_json`, where `getChangelog` compares rows byte-identically —
does not apply to package.json. The other reason, cosmetic churn across
~600 files, is one file here. A rule that is merely opinionated is not
worth a config exception.

Purely a reordering: keys, values, scripts, dependencies and
devDependencies all compare equal to the previous file.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@adamXbot
adamXbot requested a review from AdamXweb as a code owner August 4, 2026 04:40
@AdamXweb
AdamXweb merged commit 0edd1ae into main Aug 4, 2026
10 of 12 checks passed
@AdamXweb
AdamXweb deleted the fix/sort-package-json branch August 4, 2026 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants